luca-p-castelli commented on PR #955:
URL: 
https://github.com/apache/flink-kubernetes-operator/pull/955#issuecomment-2724653893

   Thanks for the review @gyfora. I've made some updates based on your 
comments. 
   
   I have also:
   
   1. Made sure the e2e test fails without the fix (i.e. fails with what's 
currently in main)
   
![image](https://github.com/user-attachments/assets/38bca1df-e702-439b-8871-da2a92b5d1d6)
   
   2. I had to change the flink-examples JAR to a newer one since 
`--execution-mode` wasn't available in 
`"https://repo1.maven.org/maven2/org/apache/flink/flink-examples-streaming_2.12/1.14.4/flink-examples-streaming_2.12-1.14.4.jar"`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to