davidradl commented on code in PR #26321:
URL: https://github.com/apache/flink/pull/26321#discussion_r2003671455
##########
flink-runtime/src/main/java/org/apache/flink/streaming/api/windowing/assigners/SlidingEventTimeWindows.java:
##########
@@ -59,6 +59,11 @@ protected SlidingEventTimeWindows(long size, long slide,
long offset) {
"SlidingEventTimeWindows parameters must satisfy "
+ "abs(offset) < slide and size > 0");
}
+ if (size / slide > 10000000) {
Review Comment:
Why can't we introduce a config for this one? Like @nilmadhab I am nervous
about hard coding a number in the code that may not be always appropriate. It
was be useful to understand how we would advise on this number.
- Is it heap related?
- I wonder what the limits of this use case for this API are, ideally from
stakeholders point of view. Rather than setting something very large that
no-one would reasonably use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
