ruanhang1993 commented on code in PR #153:
URL:
https://github.com/apache/flink-connector-jdbc/pull/153#discussion_r2004869583
##########
flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/core/datastream/sink/JdbcSink.java:
##########
@@ -74,14 +79,26 @@ public static <IN> JdbcSinkBuilder<IN> builder() {
@Override
@Internal
- public JdbcWriter<IN> createWriter(InitContext context) throws IOException
{
+ public JdbcWriter<IN> createWriter(WriterInitContext context) throws
IOException {
return restoreWriter(context, Collections.emptyList());
}
+ @Override
Review Comment:
Do we need `@Internal` here?
##########
flink-connector-jdbc-core/src/test/java/org/apache/flink/connector/jdbc/internal/JdbcFullTest.java:
##########
@@ -107,7 +108,8 @@ void testEnrichedClassCastException() {
}
private void runTest(boolean exploitParallelism) throws Exception {
- ExecutionEnvironment environment =
ExecutionEnvironment.getExecutionEnvironment();
+ ExecutionEnvironment environment = ExecutionEnvironment.getInstance();
Review Comment:
Could we delete `environment` here?
##########
flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/core/datastream/sink/JdbcSink.java:
##########
@@ -74,14 +79,26 @@ public static <IN> JdbcSinkBuilder<IN> builder() {
@Override
@Internal
- public JdbcWriter<IN> createWriter(InitContext context) throws IOException
{
+ public JdbcWriter<IN> createWriter(WriterInitContext context) throws
IOException {
return restoreWriter(context, Collections.emptyList());
}
+ @Override
+ public Committer<JdbcCommitable> createCommitter(CommitterInitContext
committerInitContext)
+ throws IOException {
+ return new JdbcCommitter(deliveryGuarantee, connectionProvider,
exactlyOnceOptions);
+ }
+
@Override
@Internal
+ public SimpleVersionedSerializer<JdbcCommitable>
getCommittableSerializer() {
+ return new JdbcCommitableSerializer();
+ }
+
+ @Override
Review Comment:
Do we need `@Internal` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
