[
https://issues.apache.org/jira/browse/FLINK-37534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937844#comment-17937844
]
david radley commented on FLINK-37534:
--------------------------------------
[~tomncooper] I agree this will help improve the quality of contributions with
PR contributors getting prompt specific feedback.
nit: On the JVM level should we use different levels for v1 or v2 targeted PRs
as they have different minimum and default JVMs?
> Add Liniting checks to all PRs
> -------------------------------
>
> Key: FLINK-37534
> URL: https://issues.apache.org/jira/browse/FLINK-37534
> Project: Flink
> Issue Type: Improvement
> Reporter: Thomas Cooper
> Priority: Not a Priority
>
> Often when a user submits a PR they will wait for the CI to run in Azure
> DevOps and this will fail as they have forgotten to run spotless or
> checkstyle. In order to find this out, the author has to dig through the
> Azure DevOps UI and often parse the logs.
> We currently have a GitHub Action for running "pre-compile" checks that
> include all the standard linting checks:
> `.github/workflows/template.pre-compile-checks.yml`
> It would be a better experience for developers if this was run for every PR
> (using the default JVM, currently 17). That way a clear indication would be
> given, via the GitHub UI, if the PR has passed the basic checks.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
