ruanhang1993 commented on code in PR #3954:
URL: https://github.com/apache/flink-cdc/pull/3954#discussion_r2013441153
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/test/java/org/apache/flink/cdc/connectors/mysql/source/MySqlSourceITCase.java:
##########
@@ -202,7 +202,20 @@ public void
testReadSingleTableWithSingleParallelismAndSkipBackFill() throws Exc
FailoverPhase.NEVER,
new String[] {tableName},
RestartStrategies.fixedDelayRestart(1, 0),
- true);
+
Collections.singletonMap("scan.incremental.snapshot.backfill.skip", "true"));
+ }
+
+ @Test
+ public void testReadSingleTableAndUnboundedChunkFirst() throws Exception {
+ testMySqlParallelSource(
+ 1,
+ DEFAULT_SCAN_STARTUP_MODE,
+ FailoverType.NONE,
+ FailoverPhase.NEVER,
+ new String[] {tableName},
+ RestartStrategies.fixedDelayRestart(1, 0),
+ Collections.singletonMap(
+
"scan.incremental.snapshot.unbounded-chunk-first.enabled", "true"));
Review Comment:
`scan.incremental.snapshot.unbounded-chunk-first.enabled` is already set by
`assignEndingFirst == null`.
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/source/assigners/ChunkRange.java:
##########
@@ -83,4 +83,9 @@ public boolean equals(Object o) {
public int hashCode() {
return Objects.hash(chunkStart, chunkEnd);
}
+
+ @Override
+ public String toString() {
+ return "ChunkRange{" + "chunkStart=" + chunkStart + ", chunkEnd=" +
chunkEnd + '}';
Review Comment:
```suggestion
return "ChunkRange{chunkStart=" + chunkStart + ", chunkEnd=" +
chunkEnd + '}';
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
