yuxiqian commented on code in PR #3707: URL: https://github.com/apache/flink-cdc/pull/3707#discussion_r2014022338
########## docs/content.zh/docs/connectors/flink-sources/mongodb-cdc.md: ########## Review Comment: Seems there's still an outdated `copy.existing.queue.size` option in English docs, which has been removed from Chinese docs in https://github.com/apache/flink-cdc/commit/aff5b0566df1fae581a21dde75f898806587355b. Should that be removed, too? <img width="907" alt="A screenshot of MongoDB CDC Docs (English version)" src="https://github.com/user-attachments/assets/89062596-7539-4792-b25c-9a0dd9faa43d"; /> ########## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mongodb-cdc/src/main/java/org/apache/flink/cdc/connectors/mongodb/table/MongoDBTableSourceFactory.java: ########## @@ -103,6 +109,18 @@ public DynamicTableSource createDynamicTableSource(Context context) { : ZoneId.of(zoneId); boolean enableParallelRead = config.get(SCAN_INCREMENTAL_SNAPSHOT_ENABLED); + + // The initial.snapshotting.pipeline config is only used in Debezium mode and + // cannot be used in incremental snapshot mode because the semantic is inconsistent. + // The reason is that in snapshot phase of incremental snapshot mode, the oplog + // will be backfilled after each snapshot to compensate for changes, but the pipeline + // operations in initial.snapshotting.pipeline are not applied to the backfill oplog, + // which means the semantic of this config is inconsistent. + checkArgument( + !(enableParallelRead && initialSnapshottingPipeline != null), Review Comment: Should we also ensure user aren't configuring other `copyExisting` options in incremental snapshot mode? ########## docs/content.zh/docs/connectors/flink-sources/mongodb-cdc.md: ########## @@ -247,6 +247,35 @@ upstart 流需要一个唯一的密钥，所以我们必须声明 `_id` 作为 <td>Long</td> <td>起始毫秒数, 仅适用于 <code>'timestamp'</code> 启动模式.</td> </tr> + <tr> + <td>initial.snapshotting.queue.size</td> + <td>optional</td> + <td style="word-wrap: break-word;">10240</td> + <td>Integer</td> + <td>进行初始快照时的队列大小。仅在 scan.startup.mode 选项设置为 initial 时生效。 + 注意：已弃用的选项名是 copy.existing.queue.size，为了兼容旧版本的作业，该选项名仍可用，但是推荐升级到新选项名 Review Comment: nit: insert a `<br>` between description and deprecation notice. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
