davidradl commented on code in PR #26334:
URL: https://github.com/apache/flink/pull/26334#discussion_r2014242913
##########
flink-rpc/flink-rpc-akka/src/main/java/org/apache/flink/runtime/rpc/pekko/PekkoRpcServiceUtils.java:
##########
@@ -294,15 +290,20 @@ public PekkoRpcServiceBuilder withCustomConfig(final
Config customConfig) {
@Override
public PekkoRpcServiceBuilder withBindAddress(final String
bindAddress) {
- this.bindAddress = Preconditions.checkNotNull(bindAddress);
+ if (bindAddress != null) {
Review Comment:
@beliefer sorry if I am not being clear.
1) if bindAddress is never null coming into this method, then we do not need
the if or the Preconditions.checkNotNull . In this case we can remove the if
and the Preconditions.checkNotNull
2) if bindAddress can be null coming into this method then
Preconditions.checkNotNull will throw a null pointer exception. So the current
change changes behaviour as the null pointer will not be thrown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
