AHeise commented on code in PR #154: URL: https://github.com/apache/flink-connector-kafka/pull/154#discussion_r2014529270
########## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/internal/TransactionNamingStrategyImpl.java: ########## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.kafka.sink.internal; + +import org.apache.flink.connector.kafka.sink.KafkaSinkOptions.TransactionNamingStrategy; + +import static org.apache.flink.util.Preconditions.checkState; + +/** Implementation of {@link TransactionNamingStrategy}. */ +public enum TransactionNamingStrategyImpl { + INCREMENTING { Review Comment: I'd like to stick to INCREMENTING. ChatGPT says: > The words "incrementing" and "incremental" are related but have different semantics: > > Incrementing (verb, present participle) > > Refers to the action of increasing something step by step. > > Example: "The counter is incrementing by one every second." > > It describes an ongoing process or operation of increasing something. > > Incremental (adjective) > > Describes something that happens in small, gradual steps. > > Example: "The software received incremental updates over time." > > It characterizes the nature of the increase rather than the action itself. > > Summary: > > "Incrementing" → Ongoing process of increasing. > > "Incremental" → Gradual or step-by-step increase in nature. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
