twalthr commented on code in PR #26374:
URL: https://github.com/apache/flink/pull/26374#discussion_r2018870460
##########
flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/stream/sql/ChangelogNormalizeOptimizationTest.xml:
##########
@@ -388,7 +428,7 @@
LogicalSink(table=[default_catalog.default_database.upsert_sink_table], fields=[
<Resource name="optimized rel plan">
<![CDATA[
Sink(table=[default_catalog.default_database.upsert_sink_table], fields=[id,
col1, col2], changelogMode=[NONE])
-+- ChangelogNormalize(key=[id], condition=[>(col1, 2)],
changelogMode=[I,UB,UA,D])
++- ChangelogNormalize(key=[id], condition=[>(col1, 2)], changelogMode=[I,UA,D])
Review Comment:
And it is guaranteed that no filter in the Calc exists that would require an
UB during push down, correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
