yuxiqian commented on code in PR #3916:
URL: https://github.com/apache/flink-cdc/pull/3916#discussion_r2022472467
##########
flink-cdc-composer/src/main/java/org/apache/flink/cdc/composer/flink/FlinkPipelineComposer.java:
##########
@@ -205,7 +205,11 @@ private void translate(StreamExecutionEnvironment env,
PipelineDef pipelineDef)
// Schema Operator -> Sink -> X
sinkTranslator.translate(
- pipelineDef.getSink(), stream, dataSink,
schemaOperatorIDGenerator.generate());
+ pipelineDef.getSink(),
+ stream,
+ parallelism,
+ dataSink,
+ schemaOperatorIDGenerator.generate());
Review Comment:
Seems sink writer's parallelism will be equivalent to CPU count if it isn't
explicitly specified, which will break newly added test cases. But splitting it
into another PR also makes sense. Any suggestions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
