davidradl commented on code in PR #26385:
URL: https://github.com/apache/flink/pull/26385#discussion_r2022481127
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableEnvironment.java:
##########
@@ -868,6 +868,62 @@ void createTemporarySystemFunction(
*/
boolean createView(String path, Table view, boolean ignoreIfExists);
+ /**
+ * Registers a Model API object as a model similar to SQL models.
+ *
+ * <p>Temporary objects can shadow permanent ones. If a temporary object
in a given path exists,
+ * the permanent one will be inaccessible in the current session. To make
the permanent object
+ * available again one can drop the corresponding temporary object.
+ *
+ * @param path The path under which the model will be registered. See also
the {@link
+ * TableEnvironment} class description for the format of the path.
+ * @param descriptor The descriptor of the model to register.
+ */
+ void createModel(String path, ModelDescriptor descriptor);
+
+ /**
+ * Registers a Model API object as a model similar to SQL models.
+ *
+ * <p>Temporary objects can shadow permanent ones. If a temporary object
in a given path exists,
+ * the permanent one will be inaccessible in the current session. To make
the permanent object
+ * available again one can drop the corresponding temporary object.
+ *
+ * @param path The path under which the model will be registered. See also
the {@link
+ * TableEnvironment} class description for the format of the path.
+ * @param descriptor The descriptor of the model to register.
Review Comment:
can we add a javadoc link to `ModelDescriptor` please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
