davidradl commented on code in PR #26385:
URL: https://github.com/apache/flink/pull/26385#discussion_r2022542816
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java:
##########
@@ -1647,6 +1675,8 @@ private void execute(
command.execute(catalog.get(),
objectIdentifier.toObjectPath());
} catch (TableAlreadyExistException
| TableNotExistException
+ | ModelNotExistException
+ | ModelAlreadyExistException
Review Comment:
nits: I now these are the same format as the table ones - so you may not wan
to change . It would be slightly better English to have
ModelNotExistException -> ModelDoesNotExistException
ModelAlreadyExistException -> ModelAlreadyExistsException
I am curious why we do not have view exceptions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
