davidradl commented on code in PR #26394:
URL: https://github.com/apache/flink/pull/26394#discussion_r2027205709
##########
flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStKeyedStateBackend.java:
##########
@@ -510,6 +519,14 @@ public void dispose() {
if (this.disposed) {
return;
}
+ // This call will block until all clients that still acquire
access to the ForSt
Review Comment:
nits:
- do you mean:
still acquire access -> still have the lock
- the comment formatting is strange - it is split of many lines.
- maybe change "so that we cannot release the native resources while clients
are still working with it in parallel." to "so that we do not release the
native resources while clients (running on different threads) are still working
with it"
- I wonder why this call blocks, we have the lock - are we going to block
holding the lock? Or is the blocking we are really talking about on the
`synchronized (lock) {`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
