davidradl commented on code in PR #26385:
URL: https://github.com/apache/flink/pull/26385#discussion_r2022498621
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java:
##########
@@ -1573,14 +1597,18 @@ public void dropModel(ObjectIdentifier
objectIdentifier, boolean ignoreIfNotExis
resolvedModel,
ignoreIfNotExists,
false)));
- } else if (!ignoreIfNotExists) {
- throw new ModelNotExistException(
- objectIdentifier.getCatalogName(),
objectIdentifier.toObjectPath());
- }
- },
- objectIdentifier,
- ignoreIfNotExists,
- "DropModel");
+ },
+ objectIdentifier,
+ ignoreIfNotExists,
+ "DropModel");
Review Comment:
nit: change to constant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
