[
https://issues.apache.org/jira/browse/FLINK-5369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15763839#comment-15763839
]
ASF GitHub Bot commented on FLINK-5369:
---------------------------------------
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3029#discussion_r93206487
--- Diff: pom.xml ---
@@ -91,7 +91,6 @@ under the License.
<flink.forkCount>1C</flink.forkCount>
<flink.reuseForks>true</flink.reuseForks>
<log4j.configuration>log4j-test.properties</log4j.configuration>
- <slf4j.version>1.7.7</slf4j.version>
--- End diff --
Why did you remove that version as a property? The reason why we add
properties for those dependencies is that users can pass a custom version via
-Dslf4j.version=1.2.3 when building Flink.
> Rework jsr305 and logging dependencies
> --------------------------------------
>
> Key: FLINK-5369
> URL: https://issues.apache.org/jira/browse/FLINK-5369
> Project: Flink
> Issue Type: Bug
> Components: Build System
> Reporter: Stephan Ewen
> Assignee: Stephan Ewen
> Fix For: 1.2.0
>
>
> Currently, every project in Flink has a hard (compile scope) dependency on
> the {{jsr305}}, {{slf4j}}, {{log4j}}, and {{commons-land3}} artifacts,
> because these dependencies are declared in the root pom.xml. That way they
> are pulled into every fat jar, including user fat jars as soon as they refer
> to a connector or library.
> We should get the {{log4j}} related dependencies out of the root pom file.
> Ideally these dependencies are only in test scope (as the default logger for
> testing) and in {{flink-dist}} and the quickstart poms. But to keep
> compatibility with the current project setups by users, we could also add
> them to {{flink-core}}.
> In addition, the projects whose artifacts usually get bundles in fat jars
> (namely {{flink-libraries}}, {{flink-connectors}}, and {{flink-metrics}}
> should override the {{slf4j}} and {{jsr305}} dependencies as provided.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
