[
https://issues.apache.org/jira/browse/FLINK-5363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15764548#comment-15764548
]
ASF GitHub Bot commented on FLINK-5363:
---------------------------------------
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/3034
[FLINK-5363] Fire timers when window state is currently empty
Before this change, when a Trigger sets a timer and that timer fires in
the future at a point when there is currently no data in the window
state, then that timer is being ignored.
This was a problem for some users because they manually set cleanup
timers and they need to be called because the trigger needs to cleanup
some state. (For normal time windows this is not a problem, but for
special cases built on top of GlobalWindows the old behaviour was
leading to problems.)
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aljoscha/flink fire-trigger-with-empty-state
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3034.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3034
----
commit b8bfdf05ae9bfb546a223c5f638016a3e18f41bb
Author: Aljoscha Krettek <[email protected]>
Date: 2016-12-18T17:33:13Z
[FLINK-5363] Fire timers when window state is currently empty
Before this change, when a Trigger sets a timer and that timer fires in
the future at a point when there is currently no data in the window
state, then that timer is being ignored.
This was a problem for some users because they manually set cleanup
timers and they need to be called because the trigger needs to cleanup
some state. (For normal time windows this is not a problem, but for
special cases built on top of GlobalWindows the old behaviour was
leading to problems.)
----
> Fire timers when window state is currently empty
> ------------------------------------------------
>
> Key: FLINK-5363
> URL: https://issues.apache.org/jira/browse/FLINK-5363
> Project: Flink
> Issue Type: Bug
> Components: Streaming
> Reporter: Aljoscha Krettek
> Assignee: Aljoscha Krettek
> Fix For: 1.2.0
>
>
> Currently, when a {{Trigger}} sets a timer and that timer fires in the future
> at a point when there is currently no data in the window state, then that
> timer is being ignored.
> This is a problem for some users because they manually set cleanup timers and
> they need to be called because the trigger needs to cleanup some state. (For
> normal time windows this is not a problem, but for special cases built on top
> of {{GlobalWindows}} the current behaviour leads to problems.)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
