akalash commented on code in PR #26320:
URL: https://github.com/apache/flink/pull/26320#discussion_r2031317302
##########
docs/layouts/shortcodes/generated/rest_v1_dispatcher.html:
##########
@@ -2879,7 +3009,72 @@
"properties" : {
"plan" : {
"type" : "object",
- "id" :
"urn:jsonschema:org:apache:flink:runtime:rest:messages:JobPlanInfo:RawJson"
+ "id" :
"urn:jsonschema:org:apache:flink:runtime:rest:messages:JobPlanInfo:Plan",
Review Comment:
I see there are still several open questions(cc. @davidradl ):
> this appears to be an issue with the open api and rest docs - that are
not generating correctly.
Kind of, the RawJson didn't generate the proper docs and rest_api indeed
looked unreadable with RawJson
> the fix seems to be to change the way we do job serialization
Yes, indeed we used to serialize it manually but right now Jackson does it
for us based on POJO class but in fact, the serialization remains the same(it's
still Jackson) but it just happens in different time/place
> on the face of it this seems a large change to a core part of Flink, that
could introduce other considerations for example how are existing job
serializations effected.
It doesn't look like a big change since, as we discussed in
(https://github.com/apache/flink/pull/26320/files#r2022598714), the result JSON
hasn't changed. So the only change is the internal representation changed from
String to Object and the documentation has more details now.
@Efrat19 maybe you have something to add.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
