autophagy commented on code in PR #26414:
URL: https://github.com/apache/flink/pull/26414#discussion_r2033173033
##########
flink-python/pyflink/common/types.py:
##########
@@ -108,6 +108,7 @@ def __init__(self, *args, **kwargs):
self._from_dict = True
else:
self._values = list(args)
+ self._from_dict = False
Review Comment:
This would set `self._from_dict` to `{'a': 'pyflink', 'b': True}` rather
than a boolean which feels a little unintuitive
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
