Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3020#discussion_r93404965
--- Diff:
flink-core/src/test/java/org/apache/flink/api/java/typeutils/RowTypeInfoTest.java
---
@@ -18,12 +18,86 @@
package org.apache.flink.api.java.typeutils;
import org.apache.flink.api.common.typeinfo.BasicTypeInfo;
+import org.apache.flink.api.common.typeinfo.TypeInformation;
+import org.apache.flink.api.common.typeutils.CompositeType;
+import org.junit.BeforeClass;
import org.junit.Test;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
+
+import static org.junit.Assert.assertArrayEquals;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNotEquals;
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.fail;
public class RowTypeInfoTest {
+ private static List<TypeInformation<?>> typeList = new ArrayList<>();
+
+
+ @BeforeClass
+ public static void setUp() throws Exception {
+ typeList.add(BasicTypeInfo.INT_TYPE_INFO);
+ typeList.add(new RowTypeInfo(
+ BasicTypeInfo.SHORT_TYPE_INFO,
+ BasicTypeInfo.BIG_DEC_TYPE_INFO));
+ typeList.add(BasicTypeInfo.STRING_TYPE_INFO);
+ }
+
+
+ @Test
+ public void testDuplicateCustomFieldNames() {
--- End diff --
Split test and use `@Test(expected = IllegalArgumentException.class)`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
