affo commented on code in PR #26438:
URL: https://github.com/apache/flink/pull/26438#discussion_r2042215030
##########
flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java:
##########
@@ -1051,6 +1051,14 @@ private SqlNode validateScopedExpression(SqlNode
topNode, SqlValidatorScope scop
if (outermostNode.isA(SqlKind.TOP_LEVEL)) {
registerQuery(scope, null, outermostNode, outermostNode, null,
false);
}
+ // ----- FLINK MODIFICATION BEGIN -----
+ if (outermostNode instanceof SqlSelect) {
+ SqlSelect select = (SqlSelect) outermostNode;
Review Comment:
Thanks you @davidradl for your review!
1. I am not isolating `select *` for just the `select` node. This is about
the star expansion in function calls only
2. This would not expand `*` alone, but only in `SqlCall`. The
implementation of that is quite hardcoded in the `SqlValidator` and I did not
touch that. However, I am able to re-use the same `expandStar` method.
Does this answer your questions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
