davidradl commented on code in PR #26431:
URL: https://github.com/apache/flink/pull/26431#discussion_r2047196173
##########
flink-runtime/src/test/java/org/apache/flink/runtime/util/profiler/ProfilingServiceTest.java:
##########
@@ -56,7 +56,7 @@ public class ProfilingServiceTest extends TestLogger {
void setUp(@TempDir Path tempDir) {
configs.set(RestOptions.MAX_PROFILING_HISTORY_SIZE,
HISTORY_SIZE_LIMIT);
configs.set(RestOptions.PROFILING_RESULT_DIR, tempDir.toString());
- profilingService = ProfilingService.getInstance(configs);
+ profilingService = ProfilingService.getInstanceForTest(configs);
Review Comment:
I can see how the change fixes the reported issue. Can this occur with the
real method?
The `ProfilingService.getInstance(configs);` creates one profilingService,
there is a class lock around the access implying this can be accessed by
multiple threads and locking is required. Can you confirm you have checked that
there are no multithreaded issue around the real
`ProfilingService.getInstance(configs);` method please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
