reta commented on code in PR #50:
URL:
https://github.com/apache/flink-connector-opensearch/pull/50#discussion_r2047855221
##########
pom.xml:
##########
@@ -380,28 +383,6 @@ under the License.
</dependencyManagement>
<profiles>
- <profile>
- <id>opensearch1</id>
- <activation>
- <jdk>[1.8,)</jdk>
- </activation>
- <modules>
- <module>flink-connector-opensearch</module>
-
<module>flink-connector-opensearch-e2e-tests</module>
- <module>flink-sql-connector-opensearch</module>
- </modules>
- </profile>
- <profile>
- <id>opensearch2</id>
- <activation>
- <jdk>[11,)</jdk>
- </activation>
- <modules>
- <module>flink-connector-opensearch2</module>
-
<module>flink-connector-opensearch2-e2e-tests</module>
- <module>flink-sql-connector-opensearch2</module>
- </modules>
- </profile>
<!-- The spotless comes from flink-connector-parent and needs
version bump to support JDK-21 -->
<profile>
Review Comment:
So the `spotless` version comes from parent POM (see please
https://github.com/apache/flink-connector-shared-utils/blob/parent_pom/pom.xml).
We could certainly override it here but that does not look right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
