loserwang1024 commented on code in PR #3950:
URL: https://github.com/apache/flink-cdc/pull/3950#discussion_r2053292573
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-postgres-cdc/src/test/java/org/apache/flink/cdc/connectors/postgres/table/PostgreSQLConnectorITCase.java:
##########
@@ -261,6 +261,110 @@ void testStartupFromLatestOffset(boolean
parallelismSnapshot) throws Exception {
result.getJobClient().get().cancel().get();
}
+ @ParameterizedTest
+ @ValueSource(booleans = {true})
+ public void testStartupFromCommittedOffset(boolean parallelismSnapshot)
throws Exception {
+ setup(parallelismSnapshot);
+ initializePostgresTable(POSTGRES_CONTAINER, "inventory");
+
Review Comment:
> The first job starts, create the replication slot, receives 2 events then
stopped. This simulates the steps 1,2,3) you mentioned.
I got it. For test stable:
1. Please give more comment.
2. scan.lsn-commit.checkpoints-num-delay = 0 will be better to make sure lsn
commit when stopping the job. Otherwise, the second turn will read earlier then
expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
