snuyanzin commented on code in PR #26474:
URL: https://github.com/apache/flink/pull/26474#discussion_r2053670854
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/JsonGenerateUtils.scala:
##########
@@ -227,6 +227,14 @@ object JsonGenerateUtils {
}
}
+ /**
+ * Determines if the parameter index is % 2, which means checking that we
only allow JSON calls
+ * for the VALUE parameter of a JSON_OBJECT call.
+ */
+ def inValuesParam(i: Int): Boolean = {
Review Comment:
I think we can drop this method if we extract the whole `if` condition into
a method.
Also about naming: it might make confused some people since in SQL there is
also `VALUES` and this method has nothing to do with it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
