loserwang1024 commented on code in PR #3988:
URL: https://github.com/apache/flink-cdc/pull/3988#discussion_r2055653749
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/source/enumerator/IncrementalSourceEnumerator.java:
##########
@@ -172,7 +181,7 @@ public void handleSourceEvent(int subtaskId, SourceEvent
sourceEvent) {
LOG.info(
"The enumerator receives notice from subtask {} for the
stream split assignment. ",
subtaskId);
- this.streamSplitTaskId = subtaskId;
+ this.streamSplitTaskIds.add(subtaskId);
Review Comment:
1. Maybe use set rather than list? Map will be better. Because same request
mabye request
2. for multiple times.
3. What if the stream split's taskId changed, for example, addSplitsBack or
restart,
4. Maybe we should a map whose key is stream split id.
I remember @ruanhang1993 used to mention it when I intruduce newly added
framework. @ruanhang1993 , CC
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
