aws-nageshvh commented on code in PR #201:
URL:
https://github.com/apache/flink-connector-aws/pull/201#discussion_r2056848275
##########
flink-connector-aws/flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/sink/KinesisStreamsSinkWriter.java:
##########
@@ -148,6 +153,38 @@ class KinesisStreamsSinkWriter<InputT> extends
AsyncSinkWriter<InputT, PutRecord
String streamArn,
Properties kinesisClientProperties,
Collection<BufferedRequestState<PutRecordsRequestEntry>> states) {
+ this(
+ elementConverter,
+ context,
+ maxBatchSize,
+ maxInFlightRequests,
+ maxBufferedRequests,
+ maxBatchSizeInBytes,
+ maxTimeInBufferMS,
+ maxRecordSizeInBytes,
+ failOnError,
+ streamName,
+ streamArn,
+ kinesisClientProperties,
+ states,
+ null);
Review Comment:
I ended up refactoring the way client/clientprovider are injected and passed
between SinkWriter and Sink which should simplify this much further. PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
