nicusX commented on code in PR #188:
URL:
https://github.com/apache/flink-connector-aws/pull/188#discussion_r2058511129
##########
flink-connector-aws/flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/reader/KinesisShardSplitReaderBase.java:
##########
@@ -50,10 +49,10 @@
/** Base implementation of the SplitReader for reading from
KinesisShardSplits. */
@Internal
public abstract class KinesisShardSplitReaderBase
- implements SplitReader<Record, KinesisShardSplit> {
+ implements SplitReader<KinesisClientRecord, KinesisShardSplit> {
Review Comment:
@Lzgpom I think the gist is, can you please change the interface back to
using `Record` in all `@Public` and `@PublicEvolving` public methods?
This would allow including the change in a minor version of the connector,
and users of `5.0.0` would be able to just update the connector version with
no code changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
