lvyanquan commented on code in PR #4007:
URL: https://github.com/apache/flink-cdc/pull/4007#discussion_r2063207244
##########
flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/transform/PostTransformOperator.java:
##########
@@ -362,16 +363,17 @@ private Tuple2<BinaryRecordData, Boolean> transformRecord(
@Nullable TransformFilterProcessor filterProcessor,
TransformContext context) {
RecordData.FieldGetter[] preFieldGetters =
info.getPreTransformedFieldGetters();
- Schema preSchema = info.getPreTransformedSchema();
- Schema postSchema = info.getPostTransformedSchema();
+
+ List<DataType> preDataTypes = info.getPreTransformedDataTypes();
+ List<DataType> postDataTypes = info.getPostTransformedDataTypes();
+
BinaryRecordDataGenerator postGenerator =
info.getPostTransformedRecordDataGenerator();
Object[] preRow = new Object[preFieldGetters.length];
for (int i = 0; i < preFieldGetters.length; i++) {
preRow[i] =
DataTypeConverter.convertToOriginal(
- preFieldGetters[i].getFieldOrNull(recordData),
- preSchema.getColumnDataTypes().get(i));
Review Comment:
I think reducing the time consumption of this `Schema.getColumnDataTypes()`
method would be more appropriate, as the caller may not be clear about the
logic behind it, and this is an immutable class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
