davidradl commented on code in PR #26521:
URL: https://github.com/apache/flink/pull/26521#discussion_r2070431133
##########
flink-libraries/flink-state-processing-api/src/main/java/org/apache/flink/state/table/SavepointConnectorOptions.java:
##########
@@ -132,8 +133,27 @@ public enum StateType {
.stringType()
.noDefaultValue()
.withDescription(
- "Defines the format class scheme for decoding
value data. "
- + "When it's not provided then it tries to
be inferred from the SQL type (only primitive types supported).");
+ Description.builder()
+ .text(
+ "Defines the format class scheme
for decoding value data. "
+ + "Either %s or %s can be
specified. "
+ + "When none of them
provided then it tries to be inferred from the SQL type (only primitive types
supported).",
Review Comment:
nit: As is the `provided` -> `are provided`.
But I did not think it reads well. We are saying there are 2 things that can
be provided, but if there is a case when they aren't.
I suggest
`%s or %s were not specified, so attempting to infer the format class
scheme from the SQL type (only primitive types supported).`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
