davidradl commented on code in PR #167:
URL: 
https://github.com/apache/flink-connector-jdbc/pull/167#discussion_r2077212733


##########
docs/content/docs/connectors/table/jdbc.md:
##########
@@ -38,12 +38,27 @@ The JDBC sink operate in upsert mode for exchange 
UPDATE/DELETE messages with th
 Dependencies
 ------------
 
+When using the JDBC connector, `flink-connector-jdbc-core`, 
`flink-connector-jdbc-${database}` and the JDBC driver needs to be added to the 
dependencies.
+
 {{< sql_connector_download_table "jdbc" >}}
 
-The JDBC connector is not part of the binary distribution.
-See how to link with it for cluster execution [here]({{< ref 
"docs/dev/configuration/overview" >}}).
+The `flink-connector-jdbc-${database}` dependency and a driver dependency are 
required to connect to a specified database.
+
+The `flink-connector-jdbc-${database}` dependencies are as follows, whose 
version should be the same as the `flink-connector-jdbc-core`:

Review Comment:
   nit: when we say `whose version` it is not obvious what we mean. I suggest 
moving it up as per my last comment.
    
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to