Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3039#discussion_r93817908
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSource.java
---
@@ -111,24 +112,17 @@
return kafkaSource;
}
- @Override
- public int getNumberOfFields() {
- return fieldNames.length;
- }
-
- @Override
public String[] getFieldsNames() {
- return fieldNames;
+ return TableSource$class.getFieldsNames(this);
}
- @Override
- public TypeInformation<?>[] getFieldTypes() {
- return fieldTypes;
+ public int[] getFieldsIndexes() {
--- End diff --
Would be better to comment why we do this. And `getFieldsIndexes` ->
`getFieldsIndices`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
