xishuaidelin commented on code in PR #26430:
URL: https://github.com/apache/flink/pull/26430#discussion_r2083772219
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/reuse/ScanReuserUtils.java:
##########
@@ -203,7 +204,13 @@ private static WatermarkPushDownSpec adjustWatermarkIndex(
String name = newFieldNames.get(i);
LogicalType type = newSourceType.getTypeAt(i);
if (name.equals(rowtimeColumn)) {
- type = new TimestampType(type.isNullable(),
TimestampKind.ROWTIME, 3);
+ if (type instanceof LocalZonedTimestampType) {
+ type =
+ new LocalZonedTimestampType(
+ type.isNullable(),
TimestampKind.ROWTIME, 3);
Review Comment:
Good question. Watermark currently supports millisecond-precision timestamps
(3 decimal places); inputs with lower precision require no processing, while
higher-precision inputs truncate beyond milliseconds without affecting
correctness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
