Github user mindprince commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2981#discussion_r93824021
  
    --- Diff: flink-contrib/docker-flink/docker-entrypoint.sh ---
    @@ -40,3 +39,6 @@ elif [ "$1" = "taskmanager" ]; then
     else
         $@
     fi
    +
    +# prevent script to exit
    +tail -f /dev/null
    --- End diff --
    
    Why is this needed?
    
    
https://github.com/apache/flink/blob/master/flink-contrib/docker-flink/Dockerfile#L49
 already prevents the container from exiting till the daemon dies.
    
    This on the other hand will never let the container exit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to