schongloo commented on code in PR #969:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/969#discussion_r2087435183
##########
flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/utils/SpecUtils.java:
##########
@@ -99,6 +99,28 @@ public static String writeSpecWithMeta(
}
}
+ public static String serializeObject(Object object, String wrapperKey) {
Review Comment:
Yes I like that name suggestion, thanks. And indeed I'm using it on
`FlinkBlueGreenDeploymentSpec` objects only but, unlike other specs, it doesn't
extend `AbstractFlinkSpec`.
##########
flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/utils/SpecUtils.java:
##########
@@ -99,6 +99,28 @@ public static String writeSpecWithMeta(
}
}
+ public static String serializeObject(Object object, String wrapperKey) {
Review Comment:
Yes I like that name suggestion, thanks. And indeed I'm using it on
`FlinkBlueGreenDeploymentSpec` objects only but, unlike other specs, it doesn't
extend `AbstractFlinkSpec`. I'll also rename the
##########
flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/utils/SpecUtils.java:
##########
@@ -99,6 +99,28 @@ public static String writeSpecWithMeta(
}
}
+ public static String serializeObject(Object object, String wrapperKey) {
Review Comment:
Yes I like that name suggestion, thanks. And indeed I'm using it on
`FlinkBlueGreenDeploymentSpec` objects only but, unlike other specs, it doesn't
extend `AbstractFlinkSpec`.
I'll also rename the corresponding opposite function
##########
helm/flink-kubernetes-operator/templates/rbac.yaml:
##########
@@ -101,6 +103,7 @@ rules:
- apiGroups:
- flink.apache.org
resources:
+ - flinkbluegreendeployments/status
- flinkdeployments/status
Review Comment:
That's the original idea but we shifted to a `has-is` relationship rather
than a `is-a` one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
