SML0127 commented on code in PR #3924:
URL: https://github.com/apache/flink-cdc/pull/3924#discussion_r2106606737
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/source/utils/JdbcChunkUtils.java:
##########
@@ -109,31 +109,31 @@ public static Object queryMin(
*/
public static Column getSplitColumn(Table table, @Nullable String
chunkKeyColumn) {
List<Column> primaryKeys = table.primaryKeyColumns();
- if (primaryKeys.isEmpty()) {
+ if (primaryKeys.isEmpty() && chunkKeyColumn == null) {
Review Comment:
@lvyanquan
I guess modified code in this PR
https://github.com/apache/flink-cdc/pull/3928 were included while rebasing.
I'll mention it after resolving this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
