lvyanquan commented on code in PR #3977:
URL: https://github.com/apache/flink-cdc/pull/3977#discussion_r2108111594
##########
flink-cdc-common/src/main/java/org/apache/flink/cdc/common/pipeline/PipelineOptions.java:
##########
@@ -92,12 +92,22 @@ public class PipelineOptions {
+ "such as
\"America/Los_Angeles\", or a custom timezone id such as \"GMT-08:00\".")
.build());
+ public static final ConfigOption<String> PIPELINE_OPERATOR_UID_PREFIX =
+ ConfigOptions.key("operator.uid.prefix")
+ .stringType()
+ .noDefaultValue()
+ .withDescription(
+ "The prefix to use for all pipeline operator UIDs.
If not set, all pipeline operator UIDs will be generated by Flink.");
+
public static final ConfigOption<String> PIPELINE_SCHEMA_OPERATOR_UID =
Review Comment:
Please add an annotation of @Deprecated.
##########
docs/content/docs/core-concept/data-pipeline.md:
##########
@@ -121,8 +121,9 @@ Note that whilst the parameters are each individually
optional, at least one of
| `local-time-zone` | The local time zone defines current session
time zone id.
| optional |
| `execution.runtime-mode` | The runtime mode of the pipeline includes
STREAMING and BATCH, with the default value being STREAMING.
| optional |
| `schema.change.behavior` | How to handle [changes in schema]({{< ref
"docs/core-concept/schema-evolution" >}}). One of: [`exception`]({{< ref
"docs/core-concept/schema-evolution" >}}#exception-mode), [`evolve`]({{< ref
"docs/core-concept/schema-evolution" >}}#evolve-mode), [`try_evolve`]({{< ref
"docs/core-concept/schema-evolution" >}}#tryevolve-mode), [`lenient`]({{< ref
"docs/core-concept/schema-evolution" >}}#lenient-mode) (default) or
[`ignore`]({{< ref "docs/core-concept/schema-evolution" >}}#ignore-mode). |
optional |
-| `schema.operator.uid` | The unique ID for schema operator. This ID
will be used for inter-operator communications and must be unique across
operators.
| optional |
+| `schema.operator.uid` | The unique ID for schema operator. This ID
will be used for inter-operator communications and must be unique across
operators. **Deprecated**: use `operator.uid.prefix` instead.
| optional |
| `schema-operator.rpc-timeout` | The timeout time for SchemaOperator to wait
downstream SchemaChangeEvent applying finished, the default value is 3 minutes.
| optional |
+| `operator.uid.prefix` | The prefix to use for all pipeline operator
UIDs. If not set, all pipeline operator UIDs will be generated by Flink.
| optional |
Review Comment:
We should clarify that this is a recommended parameter to set and explain
the reason behind it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
