davidradl commented on code in PR #26599:
URL: https://github.com/apache/flink/pull/26599#discussion_r2109317486
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java:
##########
@@ -556,12 +559,21 @@ public AdaptiveScheduler(
deploymentTimeMetrics =
new DeploymentStateTimeMetrics(jobGraph.getJobType(),
jobStatusMetricsSettings);
+ this.executionStateMetricsRegistrars = new ArrayList<>(2);
+ this.executionStateMetricsRegistrars.add(
+ new DeploymentStateTimeMetrics(jobGraph.getJobType(),
jobStatusMetricsSettings));
+ if (jobGraph.getJobType() == JobType.STREAMING) {
Review Comment:
why only for streaming? The comment lower in the code says the adaptive
scheduler only works for streaming. But this if implies non streaming job types
can come through and are processed in some way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
