lihaosky commented on code in PR #26583:
URL: https://github.com/apache/flink/pull/26583#discussion_r2110555233
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/sql/ml/SqlMLPredictTableFunction.java:
##########
@@ -87,21 +111,25 @@ public List<String> paramNames() {
@Override
public boolean checkOperandTypes(SqlCallBinding callBinding, boolean
throwOnFailure) {
- // TODO: FLINK-37780 Check operand types after integrated with
SqlExplicitModelCall in
- // validator
- return false;
+ if
(!SqlValidatorUtils.checkTableAndDescriptorOperands(callBinding, 2, 1)) {
Review Comment:
OK. I dropped the validation for descriptor in `validateCall` since it make
the column name complex and failed later stage in rel converter:
https://github.com/apache/flink/blob/master/flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java#L2250-L2254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
