davidradl commented on code in PR #26632:
URL: https://github.com/apache/flink/pull/26632#discussion_r2127076617


##########
flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/catalog/SchemaResolutionTest.java:
##########
@@ -304,6 +308,44 @@ void testSchemaResolutionErrors() {
         testError(
                 Schema.newBuilder().column("id", 
DataTypes.INT()).primaryKey("id", "id").build(),
                 "Invalid primary key 'PK_id_id'. A primary key must not 
contain duplicate columns. Found: [id]");
+

Review Comment:
   can we test with column names containing one or more "_" characters, maybe 
a_b_c__d as a column name. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to