gustavodemorais commented on code in PR #26647:
URL: https://github.com/apache/flink/pull/26647#discussion_r2131914098
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/JoinUtil.scala:
##########
@@ -144,7 +143,7 @@ object JoinUtil {
def generateConditionFunction(
tableConfig: ReadableConfig,
classLoader: ClassLoader,
- nonEquiCondition: RexNode,
+ joinCondition: RexNode,
Review Comment:
Yep, exactly. It was only used for nonEquiCondition previously and we now
use for any kind of condition
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
