gustavodemorais commented on code in PR #26647:
URL: https://github.com/apache/flink/pull/26647#discussion_r2134725088
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/stream/StreamingMultiJoinOperator.java:
##########
@@ -614,6 +615,16 @@ private Integer processRecords(
}
}
+ private static RowData newJoinedRowData(int depth, RowData joinedRowData,
RowData record) {
+ RowData newJoinedRowData;
+ if (depth == 0) {
+ newJoinedRowData = record;
+ } else {
+ newJoinedRowData = new JoinedRowData(joinedRowData, record);
Review Comment:
Yes, it's a good idea. I suggest we do it in another ticket/PR, created it
here https://issues.apache.org/jira/browse/FLINK-37917
The reason for that is that it's basically an optimization and could be
addressed after the first e2e working version. Wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
