darenwkt commented on PR #203:
URL:
https://github.com/apache/flink-connector-aws/pull/203#issuecomment-2955083455
Thanks @dannycranmer for taking a look, my understanding is that we support
two types of E2E tests [1]:
1. Localstack running on Docker
2. Actual AWS services (and require creds).
So, the main motivation of moving these tests to E2E package type 1 for me
is:
1. It takes longer time to run these tests as part of packaging step, hence
it would be more efficient to move them to E2E which runs as part of github
action instead.
2. Cleaner separation, which means the connector module only has unit tests
and all IT and E2E are moved to E2E module.
However, I can understand where you are coming from as other connectors like
Kafka [2] keeps their IT case in the connector module. Hence, I have no
objection if the preference is to keep IT case in connector module, appreciate
both you and Hong's advice on the way forward here, thank you
[1]
https://github.com/apache/flink-connector-aws/blob/main/.github/workflows/common.yml#L109-L134
[2]
https://github.com/apache/flink-connector-kafka/blob/main/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/ExactlyOnceKafkaWriterITCase.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
