becketqin commented on code in PR #26567:
URL: https://github.com/apache/flink/pull/26567#discussion_r2152675119
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/ExecutionConfigOptions.java:
##########
@@ -456,6 +456,49 @@ public class ExecutionConfigOptions {
"The max number of async retry attempts to make
before task "
+ "execution is failed.");
+ // ------------------------------------------------------------------------
+ // Async Table Function
+ // ------------------------------------------------------------------------
+ @Documentation.TableOption(execMode = Documentation.ExecMode.STREAMING)
+ public static final ConfigOption<Integer>
TABLE_EXEC_ASYNC_TABLE_MAX_CONCURRENT_OPERATIONS =
+ key("table.exec.async-table.max-concurrent-operations")
Review Comment:
Thanks Allan.
> Should I do that as part of this PR or have a followup for
AsyncScalarFunction?
Let's make it a separate PR. For the config name change in
AsyncScalarFunction, I am thinking that maybe we can do the following:
1. Reply to the vote thread of the AsyncScalarFunction FLIP to let people
know that we want to use the new config name, which is more intuitive. And for
backwards compatibility, we are going to make the old key as deprecated key.
2. If there is no objection, we can update the AsyncScalarFunction FLIP to
add the description of this change.
> I agree. It's a bit inconsistent. I think all async operations (scalar,
table, lookup joins, ml_predict) support the execution config, though only
lookup joins at the moment also support hints. Hints support could certainly be
added in the future to others. I can file jiras for each feature to add hint
support, if it can be retroactively added to old FLIPs.
Given that these are addition of new things to multiple components. It might
make sense to have a new separate FLIP, which aims to align all the SQL
physical behavior to support hints.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
