codenohup commented on PR #30: URL: https://github.com/apache/flink-agents/pull/30#issuecomment-2986846194
Thank you for your PR. This PR currently only includes some basic components, but lacks the Flink operator needed to form a complete processing loop, which makes the review process challenging. I'm not entirely clear about the purpose of each component. For example, _org.apache.flink.agents.runtime.common.ObjectOpenHashMap_ doesn't appear to be used in this PR and lacks corresponding tests. Additionally, the code lacks necessary documentation, such as: - org.apache.flink.agents.runtime.feedback.Checkpoints - org.apache.flink.agents.runtime.feedback.LockFreeBatchFeedbackQueue Both classes above are missing class-level comments. Please add the relevant content so we can better understand the code and complete the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
