xuyangzhong commented on code in PR #26649:
URL: https://github.com/apache/flink/pull/26649#discussion_r2156261079
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/utils/DeltaJoinUtil.java:
##########
@@ -72,11 +77,22 @@ public class DeltaJoinUtil {
private static final Set<Class<?>> ALL_SUPPORTED_DELTA_JOIN_UPSTREAM_NODES
=
Sets.newHashSet(StreamPhysicalTableSourceScan.class,
StreamPhysicalExchange.class);
+ /**
+ * All supported join types during delta join optimization. Only the
following join types are
+ * supported during delta join optimization. Otherwise, the regular join
will not be optimized
+ * into the delta join.
+ *
+ * <p>More join types can be added to support more patterns for delta join.
+ */
+ private static final Set<FlinkJoinType> ALL_SUPPORTED_JOIN_TYPES =
Review Comment:
remove useless code
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/physical/stream/StreamPhysicalDeltaJoin.java:
##########
@@ -76,7 +86,30 @@ public StreamPhysicalDeltaJoin(
@Override
public ExecNode<?> translateToExecNode() {
- throw new UnsupportedOperationException("Introduce delta join in
runtime later");
+ TableConfig config = unwrapTableConfig(this);
+ FunctionCallUtils.AsyncOptions asyncLookupOptions =
Review Comment:
```
FunctionCallUtils.AsyncOptions asyncLookupOptions =
new FunctionCallUtils.AsyncOptions(
config.get(ExecutionConfigOptions.TABLE_EXEC_ASYNC_LOOKUP_BUFFER_CAPACITY),
config.get(ExecutionConfigOptions.TABLE_EXEC_ASYNC_LOOKUP_TIMEOUT)
.toMillis(),
// Currently DeltaJoin only supports ordered
processing based on join key.
// However, it may be possible to support unordered
processing in certain
// scenarios to enhance throughput as much as
possible.
true,
AsyncDataStream.OutputMode.ORDERED);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
