gustavodemorais commented on code in PR #26702:
URL: https://github.com/apache/flink/pull/26702#discussion_r2157085716


##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/stream/sql/MultiJoinTest.java:
##########
@@ -154,6 +163,16 @@ void testFourWayComplexJoinRelPlan() {
                         + "LEFT JOIN Shipments s ON p.user_id_2 = 
s.user_id_3");
     }
 
+    @Test
+    void testFourWayJoinNoCJKRelPlan() {
+        util.verifyRelPlan(
+                "SELECT u.user_id_0, u.name, o.order_id, p.payment_id, 
s.location "
+                        + "FROM Users u "
+                        + "LEFT JOIN Orders o ON u.user_id_0 = o.user_id_1 "
+                        + "INNER JOIN Payments p ON u.user_id_0 = p.user_id_2 "
+                        + "LEFT JOIN Shipments s ON p.payment_id = 
s.user_id_3");
+    }
+

Review Comment:
   This still doesn't work:
   
   ```
       @Test
       void testFourWayJoinTransitiveCommonJoinKeyRelPlan() {
           util.verifyExecPlan(
                   "SELECT u.user_id_0, u.name, o.order_id, p.payment_id, 
s.location "
                           + "FROM Users u "
                           + "LEFT JOIN Orders o ON u.user_id_0 = o.user_id_1 "
                           + "LEFT JOIN Payments p ON o.user_id_1 = p.user_id_2 
"
                           + "LEFT JOIN Shipments s ON p.user_id_2 = 
s.user_id_3");
       }
       
   ```
   
   Although not 100% required for the first version.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to