AlanConfluent commented on PR #26567: URL: https://github.com/apache/flink/pull/26567#issuecomment-3002027358
> @AlanConfluent Thanks for updating the patch. I made another pass. The patch is very close to be merged. I left a couple of minor comments. We can merge it after the code is rebased to resolve the conflicts. Sounds good. Rebasing. > > There might be a few follow-up patches to complete the whole work: > > 1. Add the join type check. > 2. Add batch support. > 3. Add condition support. (This is supported in TableFunction) > > Thanks again for the patch. Honestly, it is a little surprising to me how much work it is to enable this feature. I have a followup PR that checks the join type and handles left join. I skipped tacking it on to this PR which is already large, but will make a ticket. And will create a ticket for the other items as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
