xintongsong commented on code in PR #32: URL: https://github.com/apache/flink-agents/pull/32#discussion_r2165420522
########## python/flink_agents/runtime/local_execution_environment.py: ########## @@ -0,0 +1,72 @@ +################################################################################ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +################################################################################# +from typing import Any, Dict, List + +from flink_agents.api.execution_enviroment import AgentsExecutionEnvironment +from flink_agents.api.workflow import Workflow +from flink_agents.runtime.local_runner import LocalRunner + + +class LocalExecutionEnvironment(AgentsExecutionEnvironment): + """Implementation of AgentsExecutionEnvironment for local execution environment.""" + + __input: List[Dict[str, Any]] + __output: List[Any] + __runner: LocalRunner + + def __init__(self) -> None: + """Init empty output list.""" + self.__output = [] + + def from_list(self, input: list) -> 'AgentsExecutionEnvironment': + """Set input list of execution environment.""" + self.__input = input + return self + + def apply(self, workflow: Workflow) -> 'AgentsExecutionEnvironment': + """Create local runner to execute given workflow.""" + self.__runner = LocalRunner(workflow) Review Comment: Seems local runner only support single workflow. We should also make that explicit. ########## python/flink_agents/runtime/local_execution_environment.py: ########## @@ -0,0 +1,72 @@ +################################################################################ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +################################################################################# +from typing import Any, Dict, List + +from flink_agents.api.execution_enviroment import AgentsExecutionEnvironment +from flink_agents.api.workflow import Workflow +from flink_agents.runtime.local_runner import LocalRunner + + +class LocalExecutionEnvironment(AgentsExecutionEnvironment): + """Implementation of AgentsExecutionEnvironment for local execution environment.""" + + __input: List[Dict[str, Any]] + __output: List[Any] + __runner: LocalRunner + + def __init__(self) -> None: + """Init empty output list.""" + self.__output = [] Review Comment: Does the environment support multiple `execute()` calls? If it supports, we may have dirty data from previous execution. If not, we should explicitly check against this. ########## python/flink_agents/api/execution_enviroment.py: ########## @@ -0,0 +1,80 @@ +################################################################################ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +################################################################################# +import importlib +from abc import ABC, abstractmethod +from typing import Any, Dict, List + +from flink_agents.api.workflow import Workflow + + +class AgentsExecutionEnvironment(ABC): + """Base class for workflow execution environment.""" + + @classmethod Review Comment: Any reason this is a class method rather than a static method? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
