hlteoh37 commented on code in PR #211: URL: https://github.com/apache/flink-connector-aws/pull/211#discussion_r2167143818
########## flink-connector-aws-e2e-tests/flink-formats-avro-glue-schema-registry-e2e-tests/src/test/java/org/apache/flink/glue/schema/registry/test/GSRKinesisPubsubClient.java: ########## @@ -1,113 +1,113 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed with - * this work for additional information regarding copyright ownership. - * The ASF licenses this file to You under the Apache License, Version 2.0 - * (the "License"); you may not use this file except in compliance with - * the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -package org.apache.flink.glue.schema.registry.test; - -import org.apache.flink.streaming.connectors.kinesis.testutils.KinesisPubsubClient; - -import com.amazonaws.services.schemaregistry.common.AWSDeserializerInput; -import com.amazonaws.services.schemaregistry.common.AWSSerializerInput; -import com.amazonaws.services.schemaregistry.common.configs.GlueSchemaRegistryConfiguration; -import com.amazonaws.services.schemaregistry.deserializers.GlueSchemaRegistryDeserializationFacade; -import com.amazonaws.services.schemaregistry.serializers.GlueSchemaRegistrySerializationFacade; -import com.amazonaws.services.schemaregistry.utils.AWSSchemaRegistryConstants; -import com.amazonaws.services.schemaregistry.utils.AvroRecordType; -import org.apache.avro.generic.GenericRecord; -import software.amazon.awssdk.auth.credentials.AwsCredentialsProvider; -import software.amazon.awssdk.services.glue.model.DataFormat; - -import java.nio.ByteBuffer; -import java.util.HashMap; -import java.util.List; -import java.util.Map; -import java.util.Properties; -import java.util.UUID; - -/** - * Simple client to publish and retrieve messages, using the AWS Kinesis SDK, Flink Kinesis - * Connectors and Glue Schema Registry classes. - */ -public class GSRKinesisPubsubClient { - private final KinesisPubsubClient client; - private final GlueSchemaRegistrySerializationFacade serializationFacade; - private final GlueSchemaRegistryDeserializationFacade deserializationFacade; - - public GSRKinesisPubsubClient( - Properties properties, AwsCredentialsProvider gsrCredentialsProvider) { - this.client = new KinesisPubsubClient(properties); - this.serializationFacade = createSerializationFacade(gsrCredentialsProvider); - this.deserializationFacade = createDeserializationFacade(gsrCredentialsProvider); - } - - public void sendMessage(String schema, String streamName, GenericRecord msg) { - UUID schemaVersionId = - serializationFacade.getOrRegisterSchemaVersion( - AWSSerializerInput.builder() - .schemaDefinition(schema) - .dataFormat(DataFormat.AVRO.name()) - .schemaName(streamName) - .transportName(streamName) - .build()); - - client.sendMessage( - streamName, serializationFacade.serialize(DataFormat.AVRO, msg, schemaVersionId)); - } - - public List<Object> readAllMessages(String streamName) throws Exception { - - return client.readAllMessages( - streamName, - bytes -> - deserializationFacade.deserialize( - AWSDeserializerInput.builder() - .buffer(ByteBuffer.wrap(bytes)) - .transportName(streamName) - .build())); - } - - public void createStream(String stream, int shards, Properties props) throws Exception { - client.createTopic(stream, shards, props); - } - - private Map<String, Object> getSerDeConfigs() { - Map<String, Object> configs = new HashMap<>(); - configs.put(AWSSchemaRegistryConstants.AWS_REGION, "ca-central-1"); - configs.put(AWSSchemaRegistryConstants.SCHEMA_AUTO_REGISTRATION_SETTING, true); - configs.put( - AWSSchemaRegistryConstants.AVRO_RECORD_TYPE, - AvroRecordType.GENERIC_RECORD.getName()); - - return configs; - } - - private GlueSchemaRegistrySerializationFacade createSerializationFacade( - final AwsCredentialsProvider credentialsProvider) { - return GlueSchemaRegistrySerializationFacade.builder() - .credentialProvider(credentialsProvider) - .glueSchemaRegistryConfiguration( - new GlueSchemaRegistryConfiguration(getSerDeConfigs())) - .build(); - } - - private GlueSchemaRegistryDeserializationFacade createDeserializationFacade( - final AwsCredentialsProvider credentialsProvider) { - return GlueSchemaRegistryDeserializationFacade.builder() - .credentialProvider(credentialsProvider) - .configs(getSerDeConfigs()) - .build(); - } -} +///* +// * Licensed to the Apache Software Foundation (ASF) under one or more +// * contributor license agreements. See the NOTICE file distributed with +// * this work for additional information regarding copyright ownership. +// * The ASF licenses this file to You under the Apache License, Version 2.0 +// * (the "License"); you may not use this file except in compliance with +// * the License. You may obtain a copy of the License at +// * +// * http://www.apache.org/licenses/LICENSE-2.0 +// * +// * Unless required by applicable law or agreed to in writing, software +// * distributed under the License is distributed on an "AS IS" BASIS, +// * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// * See the License for the specific language governing permissions and +// * limitations under the License. +// */ +// +//package org.apache.flink.glue.schema.registry.test; +// +//import org.apache.flink.streaming.connectors.kinesis.testutils.KinesisPubsubClient; +// +//import com.amazonaws.services.schemaregistry.common.AWSDeserializerInput; +//import com.amazonaws.services.schemaregistry.common.AWSSerializerInput; +//import com.amazonaws.services.schemaregistry.common.configs.GlueSchemaRegistryConfiguration; +//import com.amazonaws.services.schemaregistry.deserializers.GlueSchemaRegistryDeserializationFacade; +//import com.amazonaws.services.schemaregistry.serializers.GlueSchemaRegistrySerializationFacade; +//import com.amazonaws.services.schemaregistry.utils.AWSSchemaRegistryConstants; +//import com.amazonaws.services.schemaregistry.utils.AvroRecordType; +//import org.apache.avro.generic.GenericRecord; +//import software.amazon.awssdk.auth.credentials.AwsCredentialsProvider; +//import software.amazon.awssdk.services.glue.model.DataFormat; +// +//import java.nio.ByteBuffer; +//import java.util.HashMap; +//import java.util.List; +//import java.util.Map; +//import java.util.Properties; +//import java.util.UUID; +// +///** +// * Simple client to publish and retrieve messages, using the AWS Kinesis SDK, Flink Kinesis +// * Connectors and Glue Schema Registry classes. +// */ +//public class GSRKinesisPubsubClient { Review Comment: Resolved in PR https://github.com/apache/flink-connector-aws/pull/212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
