xishuaidelin commented on code in PR #26708:
URL: https://github.com/apache/flink/pull/26708#discussion_r2162910343
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/lookup/keyordered/Epoch.java:
##########
@@ -72,6 +74,7 @@ public void setOutput(Consumer<StreamElementQueueEntry<OUT>>
outputConsumer) {
public void decrementCount() {
ongoingRecordCount--;
+ Preconditions.checkState(ongoingRecordCount >= 0);
Review Comment:
Current implementation works in the mailbox thread and it is not designed to
work for multi-threads. Besides, this structure would be removed. The
AsyncExecutionController in flink-runtime would be integrated into stream
opeator as a generialized framework.
Based on this, I tend to have the current delta join operator and async key
ordered lookup operator temporarily rely on this structure without deeper
refactoring, since a more comprehensive refactoring will occur in the near
future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
